Hi, Yes. Our HW is capable of producing unfinalised hashes. Everything is fine. No. It is not broken.. It cleans up if error... - Dmitry On 11/11/10 18:17, ext Herbert Xu wrote: > On Wed, Nov 10, 2010 at 04:54:51PM +0200, Dmitry Kasatkin wrote: > >> This is not good. >> >> Driver might allocate some resources, which needs to be released. >> crypto_ahash_final() should do some kind of "cleanup" task. >> > Then your driver is broken. The whole hash API is designed around > the fact that each update operation completely stores all output > state in the memory provided, leaving no state behind in the > hardware. > > Is your hardware capable of producing unfinalised hashes? If not > then you shouldn't even be implementing an update operation in > hardware. You should instead use a software fallback. > > Cheers, > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
