On Wed, Nov 10, 2010 at 04:54:51PM +0200, Dmitry Kasatkin wrote: > This is not good. > > Driver might allocate some resources, which needs to be released. > crypto_ahash_final() should do some kind of "cleanup" task. Then your driver is broken. The whole hash API is designed around the fact that each update operation completely stores all output state in the memory provided, leaving no state behind in the hardware. Is your hardware capable of producing unfinalised hashes? If not then you shouldn't even be implementing an update operation in hardware. You should instead use a software fallback. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
