On Tue, Jul 21, 2009 at 09:07:25PM +0800, Herbert Xu wrote: > On Tue, Jul 21, 2009 at 02:25:09PM +0200, Steffen Klassert wrote: > > I just noticed that your shash version of hmac keeps the paded keys > > on the transform. I assumed the hashing to be reentrant, so I > > removed the locks arround the hash functions here. > > The padded keys are in the transform because they never change > unless you call setkey. The assumption has always been that > you should use one tfm per key. Ah, yes of course. > > > Is there a plan to move the paded keys to the request soon, > > or should we keep the locks for now and remove them later? > > You don't need to lock it since the same assumption applies to > AEAD. > I came on it because I applied the pcrypt patches on top of this one and I had to put the locks arround the hash functions to get it to work. The problem is probaply somewhere else, I'll look at it again. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
