On Tue, Jul 21, 2009 at 02:25:09PM +0200, Steffen Klassert wrote: > I just noticed that your shash version of hmac keeps the paded keys > on the transform. I assumed the hashing to be reentrant, so I > removed the locks arround the hash functions here. The padded keys are in the transform because they never change unless you call setkey. The assumption has always been that you should use one tfm per key. > Is there a plan to move the paded keys to the request soon, > or should we keep the locks for now and remove them later? You don't need to lock it since the same assumption applies to AEAD. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
