On Fri, 2009-01-16 at 11:26 +0800, Herbert Xu wrote: > On Fri, Jan 16, 2009 at 10:37:02AM +0800, Huang Ying wrote: > > > > But after checking blkcipher_walk_done() in 2.6.28, If input argument > > err != 0 and walk->flags & BLKCIPHER_WALK_SLOW != 0, when > > blkcipher_walk_done() return non-zero, walk->nbytes != 0. So I think it > > is a little fragile to use walk->nbytes == 0 indicate error. > > Right, that's a bug. Although this case shouldn't occur unless > wer have a buggy algorithm (that's why it's a WARN_ON). But as > we're handling it anyway, we should ensure that the result is sane. > > crypt: blkcipher - Fix WARN_ON handling in walk_done > > When we get left-over bits from a slow walk, it means that the > underlying cipher has gone troppo. However, as we're handling > that case we should ensure that the caller terminates the walk. > > This patch does this by setting walk->nbytes to zero. > > Reported-by: Huang Ying <ying.huang@xxxxxxxxx> I think Roel Kluin is the real reporter. Best Regards, Huang Ying
Attachment:
signature.asc
Description: This is a digitally signed message part
