On Fri, Jan 16, 2009 at 09:20:58AM +0800, Huang Ying wrote:
> On Thu, 2009-01-15 at 17:47 +0800, roel kluin wrote:
>
> > > + kernel_fpu_begin();
> > > + while ((nbytes = walk.nbytes)) {
> > > + aesni_ecb_enc(ctx, walk.dst.virt.addr, walk.src.virt.addr,
> > > + nbytes & AES_BLOCK_MASK);
> > > + nbytes &= AES_BLOCK_SIZE - 1;
> > > + err = blkcipher_walk_done(desc, &walk, nbytes);
> > > + }
> > > + kernel_fpu_end();
> > > +
> > > + return err;
> > > +}
> >
> > if blkcipher_walk_{virt,done} returns an error, don't we have to break
> > out of the loop?
> > i.e.
> >
> > while (!err && (nbytes = walk.nbytes))
> >
> > (if that's erroneous, it occurs in other places as well)
That's not necessary because blkcipher_walk_done will ensure
that walk.nbytes == 0 if there is an error.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
