On Thu, Jan 10, 2008 at 02:35:29PM +0100, Sebastian Siewior wrote: > * Herbert Xu | 2008-01-10 20:27:46 [+1100]: > > >On Thu, Jan 10, 2008 at 10:25:55AM +0100, Andi Kleen wrote: > >> > >> Then I don't think the patch should have been applied. > > > >I disagree. There isn't any evidence showing that the inlined version > >is significantly faster either. In the absence of that, the version > >with the smaller size is preferable. > I tried to get rid of all those macros in AES and replace them with > static only. I noticed that this makes the implementation slower. The Yes not unexpected. These crypto functions tend to be carefully tuned (or at least their critical loops are) and changing inlines in carefully tuned code is usually a bad idea. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
