On Tue, 27 Nov 2007 13:03:29 +0800 "rae l" <crquan@xxxxxxxxx> wrote: > -static void hexdump(unsigned char *buf, unsigned int len) > +static inline void hexdump(unsigned char *buf, unsigned int len) > { > - while (len--) > - printk("%02x", *buf++); > - > - printk("\n"); > + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET, > + 16, 1, > + buf, len, false); > } uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes down to 19,701. inlining is almost always wrong. - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html