On Mon, Nov 26, 2007 at 03:13:02PM +0800, Denis Cheng wrote: > these utilities implemented in lib/hexdump.c are more handy, please use this. > > Cc: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > Signed-off-by: Denis Cheng <crquan@xxxxxxxxx> OK this is pretty nice. But you just missed out because the GCM patches that just went in added more hexdump uses :) So could you please refresh your patch against the latest cryptodev tree? Please also clamp those long lines to 80 characters. On an unrelated note, lib/hexdump.c should not print 8-bit text even though they pass the is_print test. They just turn up as crap on Unicode terminals. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
