* Herbert Xu | 2007-11-14 22:22:53 [+0800]: >Indeed the last call to blkcipher_walk_done will free the IV if >we had to copy it due to an alignment mismatch. Since geode has >an alignment of 16 bytes, that's almost a given. Ach >You could copy from/to desc->info instead which would solve the >problem. > >However, why does op->iv exist at all? Surely we can just use >walk->iv directly and the problem goes away completely? Yes, you are absolutely right. I get rid of op->iv and copy the IV back to walk->iv in the crypt function (where I have to do it anyway). In this case, the s390 has the same bug (they copy the IV back after blkcipher_walk_done()). Howevere it will probably never get triggered because they have an aligment of 0 (what gets pushed to 3 by the crypto API if I remenber correcrtly). So a general question: Is it a must (requirement by the crypto API) to copy the IV back or not? I guess not if we move completely to async (one day) :) > >Cheers, Sebastian - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
