Re: Fwd: Re: [PATCH] iSCSI fix endieness of digest to be network byte order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 8 Nov 2007 09:18:49 +0800
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, Nov 07, 2007 at 07:04:52PM +0000, Benny Halevy wrote:
> > Am I dreaming (or just sleep deprived ;), or crc32c swabs the crc
> > one too many times on big-endian machines when CRC_LE_BITS != 1?
> 
> Your patch looks good to me since nobody in the kernel actually
> uses the crc32c functions directly.

I wonder why crc32c isn't used directly while crc32 is used directly
since they vary by only the polynomial.

Using crc32c directly might enable us to kill net/sctp/crc32c.c and
merge lib/crc32.c and lib/libcrc32c?
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux