On Wed, Nov 07, 2007 at 07:04:52PM +0000, Benny Halevy wrote: > Am I dreaming (or just sleep deprived ;), or crc32c swabs the crc > one too many times on big-endian machines when CRC_LE_BITS != 1? Your patch looks good to me since nobody in the kernel actually uses the crc32c functions directly. Please resend the patch with a change description + sign-off. BTW you can get rid of the byteorder.h inclusion with the patch. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
