On Tue, May 08, 2007 at 07:17:01PM +0200, Sebastian Siewior wrote: > > setkey() is for crypto user is defined as: > static inline int crypto_ablkcipher_setkey(struct crypto_ablkcipher > *tfm, > const u8 *key, unsigned int keylen) > { > return crypto_ablkcipher_crt(tfm)->setkey(tfm, key, keylen); > } > > If the key is not properly aligned by the caller, the cipher gets an > unaligned key. > What do you recommend? I recommend that you write a patch :) We just need some code in {cipher,blkcipher,ablkcipher}.c to check the alignment and copy it if necessary. Check out how we deal with unaligned IVs in blkcipher.c for example. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html