Tejun Heo <tj@xxxxxxxxxx> writes: > Hello, > > On Thu, Apr 03, 2014 at 12:01:23PM -0700, Linus Torvalds wrote: >> [ Extending the participants list a bit ] >> > As for using specific type for ns tag, yeah, that'd be better > regardless of this. The opaqueness is a bit extreme now. (The opaqueness has alwasy been silly but it was the compromise required to get the code merged. Sigh) With respect to cleaning up the namespace opaqueue pointers while working on the sysctls I came up with a design that is quite a bit more maintainable. The basic idea in terms of kernfs is to have an array (sized 1 for now) in the superblock of pointers to root kernfs_nodes. Then you have a nslink node type that holds the index of the kernfs_node pointer it is associated with. When following a nslink (which is unconditional because they would not be visible to userspace) the appropriate root kernfs_node is selected from the superblock and traversed to the same path as the nslink. The major benefit is that except for special cases in mounting (to populate the extra root), and following the nslink there is no extra logic to worry about or deal with. Since that winds up using ordinary kernfs_nodes, which are already reference counted in a well understood way we should be able to completely remove passive refcount to the network namespace. Since it has been clear what is needed for 3.15 and for resolving the merge conflict I am not suggesting we do anything this merge window but since we are talking about how to clean up warts in the existing design, I figured I should mention it. Eric _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers
