On Thu, Apr 3, 2014 at 12:43 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
>
> Ah, I remembered the other way around. We could leak cgroup_root
> reference, not the other way around. cgroup_mount() can be called
> multiple times for the same sb and we inc cgroup_root's ref each time
> but cgroup_kill_sb() only happens when the sb is released, so if we do
> the following,
Oh, Christ, I see what you are talking about.
That interface is all kinds of crazy.
> The cgroup_root should be destroyed but it isn't, I think. We'd need
> to bump cgroup_root's refcnt only when a new sb is created. It's
> kinda ugly. Hmmm...
Ok, so I guess we can use that "new_sb_created" thing, and I'll redo
my merge resolution to reflect that. I do find this incredibly ugly.
Linus
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers
