On Fri, 24 Dec 2010, Ben Blum wrote: > I'll add a patch to my current series to do this. Should I leave alone > the other cases where an out-of-memory causes a silent failure? > (cpuset_change_nodemask, scan_for_empty_cpusets) > Both are protected by cgroup_lock, so I think it should be a pretty simple change. cpuset_change_nodemask() is interesting because a task within an oom cpuset may be changing its own nodemask for more memory and that could easily allow the NODEMASK_ALLOC() to fail for large CONFIG_NODES_SHIFT. scan_for_empty_cpusets() is interesting to avoid leaving the hierarchy in an inconsistent state. So I think both of these would benefit from having a statically allocated nodemask protected by cgroup_lock(). _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
