Reviewed-by: Oren Laadan <orenl@xxxxxxxxxxxxxxx>
(but see nit below)
On 09/23/2010 05:53 PM, Matt Helsley wrote:
> Separate the __user pathname handling from the bulk of the syscall.
> Since we're doing this to enable relinking of unlinked files by
> sys_checkpoint and not sys_linkat we're not using a sys-wrapper.
>
> Signed-off-by: Matt Helsley<matthltc@xxxxxxxxxx>
> Cc: containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: Oren Laadan<orenl@xxxxxxxxxxxxxxx>
> Cc: Amir Goldstein<amir73il@xxxxxxxxxxxx>
> Cc: linux-fsdevel@xxxxxxxxxxxxxxx
> Cc: Al Viro<viro@xxxxxxxxxxxxxxxxxx>
> Cc: Christoph Hellwig<hch@xxxxxxxxxxxxx>
> Cc: Jamie Lokier<jamie@xxxxxxxxxxxxx>
...
> /*
> * Hardlinks are often used in delicate situations. We avoid
> * security-related surprises by not following symlinks on the
> @@ -2468,11 +2513,10 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de
> SYSCALL_DEFINE5(linkat, int, olddfd, const char __user *, oldname,
> int, newdfd, const char __user *, newname, int, flags)
> {
> - struct dentry *new_dentry;
> struct nameidata nd;
> struct path old_path;
> - int error;
> char *to;
> + int error;
This little piece is unnecessary ;)
[...]
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
