BH> What about: BH> 1. Multicast BH> 2. Device config info (ipv4_devconf) <snip> BH> What about addr->ifa_flags and all the other elements like BH> prefixlen, scope and label? I thought I was covered by calling it "Basic support..." :) I've added these to the list of TODOs and will cook those up once the basic bits are in. >> + if ((ret >= 0) && (ret != h->inet4_addrs)) { >> + ret = -EBUSY; >> + ckpt_err(ctx, ret, >> + "Addresses on interface %s changed\n", dev->name); >> + goto out; >> + } BH> This isn't guaranteed to catch every change to the address list, BH> just that the number of addresses is the same, is there no way to BH> hold a lock the whole time? Yeah, there probably is. I'll take a look. Thanks! -- Dan Smith IBM Linux Technology Center email: danms@xxxxxxxxxx _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers