serue@xxxxxxxxxx wrote: > From: Serge E. Hallyn <serue@xxxxxxxxxx> > > Move setting of ctx->errno into do_ckpt_msg(). We leave a small separate > function to notify all restarting tasks in case of failure. We use a > CKPT_CTX_WOKEN bit for this. If we always notify restarting tasks of > failure inside do_ckpt_msg() then we will have to be more careful about > when ckpt_err() is called at restart. Only 4 instances were doing the I don't think it is wrong to notify of errors and wakeup tasks "too early" or multiple times. In fact, the first one to notify an error (test-and-set of ctx->errno) should do that. What am I missing ? > wakeup right now (at the end of each possible restart sequence), and we > don't want to risk moving notification too early. > > This patch also fixes what should have been a problem before: always > init_completion(&complete), else we might complete(&complete) on random junk Nice catch. [...] Oren. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
