Re: [PATCH 5/7] kernel/cred.c: ckpt_err at restart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




serue@xxxxxxxxxx wrote:
> From: Serge E. Hallyn <serue@xxxxxxxxxx>
> 
> Signed-off-by: Serge E. Hallyn <serue@xxxxxxxxxx>
> ---
>  kernel/cred.c |   46 ++++++++++++++++++++++++++++++++++++----------
>  1 files changed, 36 insertions(+), 10 deletions(-)
> 
> diff --git a/kernel/cred.c b/kernel/cred.c
> index 62d28a4..c941078 100644
> --- a/kernel/cred.c
> +++ b/kernel/cred.c
> @@ -764,32 +764,46 @@ static struct cred *do_restore_cred(struct ckpt_ctx *ctx)
>  	int i;
>  
>  	h = ckpt_read_obj_type(ctx, sizeof(*h), CKPT_HDR_CRED);
> -	if (IS_ERR(h))
> +	if (IS_ERR(h)) {
> +		ckpt_err(ctx, ret, "reading cred entry\n");

This error is better reported for _all_ callers of ckpt_read_obj_type()
from that function ?

I am thinking that moving the report to the specific place where an
error occurs, plus data from the image file (and location there)
should be sufficient for debugging.

[...]

Oren.

_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers

[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux