Quoting Dan Smith (danms@xxxxxxxxxx):
> SH> ckpt_hdr_put(ctx, in) ?
>
> Oops.
>
> >> + un->this = ckpt_obj_lookup_add(ctx, sk, CKPT_OBJ_SOCK, &new);
> >> + if (un->this < 0)
> >> + goto out;
> >> +
> >> + if (sk->peer)
> >> + un->peer = ckpt_obj_lookup_add(ctx, pr, CKPT_OBJ_SOCK, &new);
> >> + else
> >> + un->peer = 0;
> >> +
> >> + if (un->peer < 0) {
> >> + ret = un->peer;
> >> + goto out;
> >> + }
>
> SH> So what if new == 1 for either un->this or un->peer? You never
> SH> actually write them out to the checkpoint image?
>
> On the checkpoint run, the new flag doesn't matter to us (and isn't
> used here). Am I missing something?
Well when is do_sock_file_checkpoint() going to be called?
> SH> ckpt_hdr_put(ctx, un) ?
>
> Oops.
>
> SH> ckpt_hdr_socket_in(ctx, in)?
>
> I think you mean:
>
> ckpt_hdr_put(ctx, in);
>
> and if so: Oops :)
Heh, no, I want you to
#define ckpt_hdr_socket_in ckpt_hdr_put
and then use ckpt_hdr_socket_in(ctx, in).
j/k
-serge
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
