"Serge E. Hallyn" <serue@xxxxxxxxxx> writes: > Quoting Dave Hansen (dave@xxxxxxxxxxxxxxxxxx): >> >> This should work around the compile issues that Nathan >> pointed out yesterday. It's too bad that 'select' is >> such a blunt object. We could surely use a soft select >> or something. But this hacks around it a bit. >> >> Create a separate "*_NS_DEP" Kconfig option for the >> dependencies for each namespace. Make the real config >> option and the c/r 'select' bot dependent on the new >> common one. >> >> This should at least keep compile errors from being >> introduced. Whether this is rude or not is a separate >> questions. :) > > Yeah I'm not sure I'm a fan of this... > > While I hate chasing down missing dependencies, maybe > CONFIG_CHECKPOINT should just depend on all the namespaces > instead of selecting them? > > I'd assumed that was Nathan was really asking for, though > I could be wrong. I was mainly interested in preventing build breaks. :) While Oren's checkpoint implementation is useful with any combination of the *_NS config options, ensuring that the kernel builds and functions correctly with all the permutations looks non-trivial. Making CHECKPOINT depend on all the *_NS options looks like an easy way to avoid the mess. Dave's patches seem to provide the maximum amount of flexibility, but my suspicion is that most interested parties tend to turn on all of *_NS anyway (as distros are starting to do), and that other configurations (e.g. CHECKPOINT=y, NET_NS=n) simply won't get test coverage in practice. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
