On Sun, 2009-05-31 at 21:55 +0200, Jarek Poplawski wrote: > But then, there could be "tc filter replace" with only this > (n->nlmsg_type == RTM_NEWTFILTER && (n->nlmsg_flags&(NLM_F_CREATE))) > which can't get here with a newly created tp, I guess. Right - because in that case tp would already exist and would be found in the lookup. > I'm almost sure these commands (right or wrong) can trigger such a > leak: > > $ sudo tc qdisc add dev lo root handle 1: htb > $ sudo tc filter add dev lo proto ip pref 1 handle 800::1 u32 match u32 0 0 classid 1:1 > $ sudo tc filter add dev lo proto ip pref 2 handle 800::1 u32 match u32 0 0 classid 1:1 > RTNETLINK answers: File exists You are good - A tip of my hat and a wag of my finger at you;-> Ok, now i looked a lot closer at all 8 classifiers and u32 is the only one that can fault. It just needs to be fixed. I will wait until Minoru's patch and then i will submit a fix for it. Of course the commands from user space are a little rude ;-> cheers, jamal _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
