Paul Menage wrote: > On Wed, Jan 7, 2009 at 1:33 AM, Li Zefan <lizf@xxxxxxxxxxxxxx> wrote: >>> Yes, I like that. Will update the patch. I assume that I must check >>> list_empty(&cgroup->children)? >> Yes. >> >>> Should I use cgroup_lock()/cgroup_unlock() >> Yes. > > For checking the "children" list, you can just lock > ipaddr_subsys.hierarchy_mutex. > Unfortunately hierarchy_mutex can't be used here, since hierarchy_mutex doesn't protect subsys's create() method, and the create() will access parent cgroup's data. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers