On Sat, 05 Jul 2008 21:42:57 -0700, ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote: > > > These patches are based off of 2.6.26-rc8 + the -gregkh tree from > > last night. Hopefully that means they apply -mm -gregkh and > > -linux-next. > > A quick update. My patchset conflicts with the recently added > driver-core-suppress-sysfs-warnings-for-device_rename.patch > > > driver core: Suppress sysfs warnings for device_rename(). > > > > Renaming network devices to an already existing name is not > > something we want sysfs to print a scary warning for, since the > > callers can deal with this correctly. So let's introduce > > sysfs_create_link_nowarn() which gets rid of the common warning. > > This patch is unnecessary as that path is never exercised anymore. > as: dev_change_name returns early in the case of a noop rename. My impression was that the networking folks didn't want any warnings for renaming failures, not just not for renaming a device to the same name. > > In addition my introduction sysfs_rename_link handles this case > cleanly by first removing the old link and then creating the new > link. Preventing false positives when the link names are the same. sysfs_rename_link() looks cleaner, I agree. > > So it should be safe to drop Cornelia patch without a reoccurance > of scary errors. Hm, the description looks badly worded - I unfortunately left the old text unchanged when I respun the patch :( The patch re-introduces the warning in sysfs_add_one() which had been removed in the meanwhile and makes device_rename() use a non-warning version. I still think we want a warning for the general case since this is usually caused be some problems in the calling code (and the alternative would be to add checks to all callers.) _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
