Tejun Heo <htejun@xxxxxxxxx> writes: > Is it difficult to just export it via kobject and device layer? Well gregkh thought it wasn't a good idea last time I tried exploring that. > If > changing the default function is too much of a hassle (and I'm sure it > would be), just add an extended version which takes @tag. The current > implementation feels like it tried too hard to not add intermediate > interfaces and ended up shooting outside from the innermost layer. It tried for something that was simple to use and that worked. Also the way things work. I have to use all of the intermediate layers and their calls to various functions. So just passing a parameter through doesn't work to well. It looks to me like the clean solution is move kobject_tag into kobj_type, and have it call some higher level function. We also need to remove the maintenance disaster that is kobject_set_name from sysfs_rename_dir. And push it into kobject_rename instead. The error handling is harder in that case but otherwise we should be in good shape. >> On the other side I can't pass a tag through from the device layer to >> the kobject layer. It isn't a concept the kobject layer supports. > > I think it's best to make kobject layer support it. Assuming Greg will accept it when he sees reasonable patches. Eric _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
