>> I'd prefer #ifdef rather than #ifndef. >> >> so... >> >> #ifdef CONFIG_CGROUP_SWAP_RES_CTLR >> your definition >> #else >> original definition >> #endif >> > OK. > I'll change it. Thanks. >> and vm_swap_full() isn't page granularity operation. >> this is memory(or swap) cgroup operation. >> >> this argument is slightly odd. >> > But what callers of vm_swap_full() know is page, > not mem_cgroup. > I don't want to add to callers something like: > > pc = get_page_cgroup(page); > mem = pc->mem_cgroup; > vm_swap_full(mem); perhaps, I don't understand your intention exactly. Why can't you make wrapper function? e.g. vm_swap_full(page_to_memcg(page)) _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers