Hi, On 2008/05/22 17:00 +0900, KOSAKI Motohiro wrote: > Hi, > >> +#ifndef CONFIG_CGROUP_SWAP_RES_CTLR >> /* Swap 50% full? Release swapcache more aggressively.. */ >> -#define vm_swap_full() (nr_swap_pages*2 < total_swap_pages) >> +#define vm_swap_full(page) (nr_swap_pages*2 < total_swap_pages) >> +#else >> +#define vm_swap_full(page) swap_cgroup_vm_swap_full(page) >> +#endif > > I'd prefer #ifdef rather than #ifndef. > > so... > > #ifdef CONFIG_CGROUP_SWAP_RES_CTLR > your definition > #else > original definition > #endif > OK. I'll change it. > and vm_swap_full() isn't page granularity operation. > this is memory(or swap) cgroup operation. > > this argument is slightly odd. > But what callers of vm_swap_full() know is page, not mem_cgroup. I don't want to add to callers something like: pc = get_page_cgroup(page); mem = pc->mem_cgroup; vm_swap_full(mem); Thanks, Daisuke Nishimura. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
