On Mon, 15 Oct 2007 15:37:01 +0900 (JST) yamamoto@xxxxxxxxxxxxx (YAMAMOTO Takashi) wrote: > > - changed from u64 to s64 > > why? > > > +/* > > + * For batching....mem_cgroup_charge_statistics()(see below). > > + */ > > +static inline void mem_cgroup_stat_add(struct mem_cgroup_stat *stat, > > + enum mem_cgroup_stat_index idx, int val) > > +{ > > + int cpu = smp_processor_id(); > > + stat->cpustat[cpu].count[idx] += val; > > +} > > i think the function name should be something which implies batching. > Hm, How about this ? == mem_cgroup_stat_add_atomic() == and add this == VM_BUG_ON(preempt_count() == 0) == > > @@ -207,8 +299,23 @@ clear_page_cgroup(struct page *page, str > > } > > > > > > -static void __mem_cgroup_move_lists(struct page_cgroup *pc, bool active) > > +static void __mem_cgroup_move_lists(struct page_cgroup *pc, bool active, > > + struct mem_cgroup *mem) > > { > > can mem be different from pc->mem_cgroup here? > Ah, always pc->mem_cgroup. ok, I'll remove that. Thanks, -Kame _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers