Eric W. Biederman wrote: > Kirill Korotaev <dev at sw.ru> writes: > > >>>I guess we need to maintain a list of task_structs in the pspace and walk >>>that list. Will work on that as a separate patch. >> >>wait. we either need to have a list of _pids_ or it >>should be called task_namespace, not pid, since we are adding more >>code related to tasks. > > > There will be a way to iterate through all of the pids. > > It will probably be through a linked list of struct pid, but > it may be an in order traversal of some pid related data structure. > > I was hoping for a moment I might be able to only implement one > struct pid, but I need some method to perform a reverse lookup > from struct pid to a (struct pid_namespace, pid_t) pair to > properly implement pid_nr(). A linked list of struct pid entries > is the obvious implementation. I guess there will be a need of list of tasks... not of pids only... many of loops like do_each_thread()/while_each_thread() has nothing to do with pids and should be narrowed down to loop through the container. Does this logic belong to pid_ns? if yes, then it definetely should be called task_ns. Kirill