On Thursday 09 June 2011 20:55:17 Timur Tabi wrote: > Arnd Bergmann wrote: > > Then get rid of all the code that takes apart the ioctl command numbers > > again and just do a switch/case based on the command. > > I still need to keep that code to maintain binary compatibility with existing > applications that pass the union as a parameter. > > I'll fix that after we've updated the applications. But we have a > chicken-or-the-egg problem where we need the same application to work with the > new and old ioctl interface for a period of time. The lesson to learn here is obviously not to ship binaries of applications to customers before the driver has been merged in a mainline kernel. The best way out that I can see is to make the driver carry the proper interface in the upstream version, but to have a private patch to support both interface versions in the kernel you ship on machines that require backwards compatibility. Once you have phased out the user application, you can then drop that patch and use the upstream version of the interfaces. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-console" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
