On Fri, Dec 6, 2024 at 6:11 AM Ralph Boehme <slow@xxxxxxxxx> wrote: > > Hi Steve > > thanks for digging into this! > > On 12/5/24 1:06 AM, Steve French wrote: > > I updated patch 2 > > (0002-fs-smb-client-Implement-new-SMB3-POSIX-type.patch) to address > > various checkpatch warnings, > > oh, sorry for those! I'll try to remember to run it myself next time. > > > and added one small changeset to fix > > mounts to older servers which don't fill in the file type in the level > > 100 Mode field (0004-smb3.1.1-fix-posix-mounts-to-older-servers.patch), > > and updated them in cifs-2.6.git for-next. Let me know if any > > objections. > > hm, not sure I like adding code to support non compliant SMB3 POSIX > server implementations at this early stage of implementing them across > various projects, clients and servers. Can't Namjae just fix it in ksmbd? We will make sure ksmbd is changed to fill in the file type, but we should reduce risks (where fix is easy) of breaking mounts to existing servers, especially since this has been in for more than three years and since the sanity check is safe and easy (ATTRIBUTE_DIRECTORY will always be set correctly by a server). There is also at least one other server that implemented earlier version of the SMB3.1.1 POSIX Extensions so better to be safe when we can do a minor check like this on the client so we don't risk any regressions, and it also will reduce risk of a future server bug breaking mounts. -- Thanks, Steve
