Hi Steve thanks for digging into this! On 12/5/24 1:06 AM, Steve French wrote:
I updated patch 2 (0002-fs-smb-client-Implement-new-SMB3-POSIX-type.patch) to address various checkpatch warnings,
oh, sorry for those! I'll try to remember to run it myself next time.
and added one small changeset to fix mounts to older servers which don't fill in the file type in the level 100 Mode field (0004-smb3.1.1-fix-posix-mounts-to-older-servers.patch), and updated them in cifs-2.6.git for-next. Let me know if any objections.
hm, not sure I like adding code to support non compliant SMB3 POSIX server implementations at this early stage of implementing them across various projects, clients and servers. Can't Namjae just fix it in ksmbd?
It looks like it does make a big improvement in reporting special files when mounted to Samba, but want to figure out why the dentry cache (revalidate call) still requires the extra roundtrip per file when doing "ls -l" (there may be a way that this enhanced query dir output could be recognized as still valid, and reduce need for extra queries).
it should only do an extra roundtrip when needed for symlinks, character and block devices as for those we wee need additional info. But for fifos and sockets the SMB2-FIND POSIX-infolevel is sufficient and in my testing I didn't see extra roundtrips for those.
Thanks! -slow
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature
