Re: [PATCH][SMB3 client] minor updates to "stop flooding dmesg" patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Steve French <smfrench@xxxxxxxxx> writes:

> We still will need to have a way to log these messages at least every few
> minutes if error in session setup. That is Clifton critical information for
> user to know

Agreed.  I just think that "\\<srv> Send error in SessSetup = ..."
doesn't really mean anything to the user.  Further I/Os from the user
will fail with -ENOKEY, which also doesn't tell much.

Without this message we at least have

        VFS: \\srv has not responded in N seconds. Reconnecting...

which tells the user that connection was lost.  And, in case server
dropped the session (e.g. STATUS_USER_SESSION_DELETED), we'll also have
the above message printed out as we currently mark tcp ses for
reconnect.

We still need to handle these excessive upcalls as in my example we have
several kworkers attempting to reconnect a SMB session (on every 2s) and
then repeatedly failing due to expired key.  This could be done in a
different patch, though.




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux