Re: [PATCH][SMB3 client] minor updates to "stop flooding dmesg" patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Steve French <smfrench@xxxxxxxxx> writes:

> I was not as comfortable with taking out where the error is logged on
> session setup, but the other parts of the two patches below were fine.
> So have added them back into for-next after the one small change to "
> smb: client: stop flooding dmesg on failed session setups"

NAK.  These changes just invalidated the patch entirely.  Either remove
it or make the "Send error in SessSetup" error messages being printed
out only once.

The client can still flood dmesg with "\\<hostname> Send error in
SessSetup = ..." messages over failed session setups with this patch.

Just try it yourself:

  kinit ...
  for i in `seq 300`; do mount.cifs //srv/share /mnt -o sec=krb5,echo_interval=5,nosharesock,nohandlecache; done
  # disconnect srv
  sleep 30
  kdestroy -A
  # reconnect srv
  journalctl -k -f
  ...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  CIFS: VFS: \\srv has not responded in 15 seconds. Reconnecting...
  cifs_setup_session: 23 callbacks suppressed
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  cifs_setup_session: 1618 callbacks suppressed
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  cifs_setup_session: 1786 callbacks suppressed
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  cifs_setup_session: 1728 callbacks suppressed
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  CIFS: VFS: \\srv Send error in SessSetup = -126
  ...




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux