On Thu, Aug 22, 2024 at 12:30 PM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote:
>
> On Sat, Aug 17, 2024 at 10:39 AM Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > This does not fix the umount/mount busy errors you see with tests like
> > generic/043 and generic/048 but it does fix the rmmod problem. And
> > FYI there is a workaround for fixing the umount/mount issues in those
> > tests - by simply adding a 1 second delay in umount. We need to
> > continue to debug the generic/043 and generic/048 umount busy errors
> >
> >
> > On Fri, Aug 16, 2024 at 4:56 PM Steve French <smfrench@xxxxxxxxx> wrote:
> > >
> > > smb3: fix problem unloading module due to leaked refcount on shutdown
> > >
> > > The shutdown ioctl can leak a refcount on the tlink which can
> > > prevent rmmod (unloading the cifs.ko) module from working.
> > >
> > > Found while debugging xfstest generic/043
> > >
> > > Fixes: 69ca1f57555f ("smb3: add dynamic tracepoints for shutdown ioctl")
> > >
> > > See attached
> > >
> > > --
> > > Thanks,
> > >
> > > Steve
> >
> >
> >
> > --
> > Thanks,
> >
> > Steve
>
> Looks good to me.
> Did you do a cursory check to see if we drop references in all other
> places where we call cifs_sb_tlink? Just for completeness?
I have checked almost all (46) places we call it last week, but will
check the remaining ones today.
--
Thanks,
Steve
