Re: Netfs failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Probably regression in rc4 affecting xfstest generic/125

it also happened with multichannel with current mainline, but doesn't
look like it happened with rc3

http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/5/builds/207/steps/57/logs/stdio

Is it possible it is related to this patch which is in the failing
(rc4) branch but not in rc3 (where the test passes)?

commit e3786b29c54cdae3490b07180a54e2461f42144c
Author: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
Date:   Thu Aug 8 14:29:38 2024 +0100

    9p: Fix DIO read through netfs

    If a program is watching a file on a 9p mount, it won't see any change in
    size if the file being exported by the server is changed directly in the
    source filesystem, presumably because 9p doesn't have change notifications,
    and because netfs skips the reads if the file is empty.

diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c
index b2405dd4d4d4..3f3842e7b44a 100644
--- a/fs/smb/client/file.c
+++ b/fs/smb/client/file.c
@@ -217,7 +217,8 @@ static void cifs_req_issue_read(struct
netfs_io_subrequest *subreq)
                        goto out;
        }

-       __set_bit(NETFS_SREQ_CLEAR_TAIL, &subreq->flags);
+       if (subreq->rreq->origin != NETFS_DIO_READ)
+               __set_bit(NETFS_SREQ_CLEAR_TAIL, &subreq->flags);

        rc = rdata->server->ops->async_readv(rdata);
 out:
(END)

On Sun, Aug 18, 2024 at 7:24 PM Steve French <smfrench@xxxxxxxxx> wrote:
>
> Do you recognize this netfs failure (generic/125) that I just saw with
> current mainline
>
> http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/9/builds/106/steps/54/logs/stdio
>
> [Sun Aug 18 18:40:43 2024] <TASK>
> [Sun Aug 18 18:40:43 2024] ? __warn+0xa4/0x220
> [Sun Aug 18 18:40:43 2024] ? netfs_subreq_terminated+0x3f0/0x4b0 [netfs]
> [Sun Aug 18 18:40:43 2024] ? report_bug+0x1d4/0x1e0
> [Sun Aug 18 18:40:43 2024] ? handle_bug+0x42/0x80
> [Sun Aug 18 18:40:43 2024] ? exc_invalid_op+0x18/0x50
> [Sun Aug 18 18:40:43 2024] ? asm_exc_invalid_op+0x1a/0x20
> [Sun Aug 18 18:40:43 2024] ? irq_work_claim+0x1e/0x40
> [Sun Aug 18 18:40:43 2024] ? netfs_subreq_terminated+0x3f0/0x4b0 [netfs]
>
> $ git log --oneline -3
> b5e99e6c6dcd (HEAD -> for-next, origin/for-next) smb3: fix problem
> unloading module due to leaked refcount on shutdown
> e4be320eeca8 smb3: fix broken cached reads when posix locks
> 47ac09b91bef (tag: v6.11-rc4, origin/master, origin/HEAD,
> linus/master, master) Linux 6.11-rc4
>
>
> Ideas?
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve





[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux