I was able to repro the generic/210 regression to Samba server as well [ 7884.205037] Workqueue: cifsiod smb2_readv_worker [cifs] [ 7884.205262] RIP: 0010:netfs_subreq_terminated+0x3f0/0x4b0 [netfs] [ 7884.205299] Code: 01 00 00 e8 02 b4 07 df 4c 8b 4c 24 08 49 89 d8 4c 89 e9 41 8b b4 24 d4 01 00 00 44 89 f2 48 c7 c7 40 10 65 c1 e8 30 a9 b6 de <0f> 0b 48 8b 7c 24 18 4c 8d bd c0 00 00 00 e8 2d b5 07 df 48 8b 7c [ 7884.205305] RSP: 0018:ff1100010705fce8 EFLAGS: 00010286 [ 7884.205312] RAX: dffffc0000000000 RBX: 0000000000001000 RCX: 0000000000000027 [ 7884.205317] RDX: 0000000000000027 RSI: 0000000000000004 RDI: ff110004cb1b1a08 [ 7884.205322] RBP: ff11000119450900 R08: ffffffffa03e346e R09: ffe21c0099636341 [ 7884.205326] R10: ff110004cb1b1a0b R11: 0000000000000001 R12: ff11000137b68a80 [ 7884.205330] R13: 000000000000012c R14: 0000000000000001 R15: ff11000126a96f78 [ 7884.205335] FS: 0000000000000000(0000) GS:ff110004cb180000(0000) knlGS:0000000000000000 [ 7884.205339] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 7884.205344] CR2: 00007f0035f0a67c CR3: 000000000f664004 CR4: 0000000000371ef0 [ 7884.205354] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 7884.205359] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 7884.205363] Call Trace: [ 7884.205367] <TASK> [ 7884.205373] ? __warn+0xa4/0x220 [ 7884.205386] ? netfs_subreq_terminated+0x3f0/0x4b0 [netfs] [ 7884.205423] ? report_bug+0x1d4/0x1e0 [ 7884.205436] ? handle_bug+0x42/0x80 [ 7884.205442] ? exc_invalid_op+0x18/0x50 [ 7884.205449] ? asm_exc_invalid_op+0x1a/0x20 [ 7884.205464] ? irq_work_claim+0x1e/0x40 [ 7884.205475] ? netfs_subreq_terminated+0x3f0/0x4b0 [netfs] [ 7884.205512] ? netfs_subreq_terminated+0x3f0/0x4b0 [netfs] [ 7884.205554] process_one_work+0x4cf/0xb80 [ 7884.205573] ? __pfx_lock_acquire+0x10/0x10 [ 7884.205582] ? __pfx_process_one_work+0x10/0x10 [ 7884.205599] ? assign_work+0xd6/0x110 [ 7884.205609] worker_thread+0x2cd/0x550 [ 7884.205622] ? __pfx_worker_thread+0x10/0x10 [ 7884.205632] kthread+0x187/0x1d0 [ 7884.205639] ? __pfx_kthread+0x10/0x10 [ 7884.205648] ret_from_fork+0x34/0x60 [ 7884.205655] ? __pfx_kthread+0x10/0x10 [ 7884.205661] ret_from_fork_asm+0x1a/0x30 [ 7884.205684] </TASK> [ 7884.205688] irq event stamp: 23635 [ 7884.205692] hardirqs last enabled at (23641): [<ffffffffa022b58b>] console_unlock+0x15b/0x170 [ 7884.205699] hardirqs last disabled at (23646): [<ffffffffa022b570>] console_unlock+0x140/0x170 [ 7884.205705] softirqs last enabled at (23402): [<ffffffffa0131a6e>] __irq_exit_rcu+0xfe/0x120 [ 7884.205712] softirqs last disabled at (23397): [<ffffffffa0131a6e>] __irq_exit_rcu+0xfe/0x120 [ 7884.205718] ---[ end trace 0000000000000000 ]--- On Mon, Aug 19, 2024 at 12:15 AM Steve French <smfrench@xxxxxxxxx> wrote: > > Probably regression in rc4 affecting xfstest generic/125 > > it also happened with multichannel with current mainline, but doesn't > look like it happened with rc3 > > http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/5/builds/207/steps/57/logs/stdio > > Is it possible it is related to this patch which is in the failing > (rc4) branch but not in rc3 (where the test passes)? > > commit e3786b29c54cdae3490b07180a54e2461f42144c > Author: Dominique Martinet <asmadeus@xxxxxxxxxxxxx> > Date: Thu Aug 8 14:29:38 2024 +0100 > > 9p: Fix DIO read through netfs > > If a program is watching a file on a 9p mount, it won't see any change in > size if the file being exported by the server is changed directly in the > source filesystem, presumably because 9p doesn't have change notifications, > and because netfs skips the reads if the file is empty. > > diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c > index b2405dd4d4d4..3f3842e7b44a 100644 > --- a/fs/smb/client/file.c > +++ b/fs/smb/client/file.c > @@ -217,7 +217,8 @@ static void cifs_req_issue_read(struct > netfs_io_subrequest *subreq) > goto out; > } > > - __set_bit(NETFS_SREQ_CLEAR_TAIL, &subreq->flags); > + if (subreq->rreq->origin != NETFS_DIO_READ) > + __set_bit(NETFS_SREQ_CLEAR_TAIL, &subreq->flags); > > rc = rdata->server->ops->async_readv(rdata); > out: > (END) > > On Sun, Aug 18, 2024 at 7:24 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > Do you recognize this netfs failure (generic/125) that I just saw with > > current mainline > > > > http://smb311-linux-testing.southcentralus.cloudapp.azure.com/#/builders/9/builds/106/steps/54/logs/stdio > > > > [Sun Aug 18 18:40:43 2024] <TASK> > > [Sun Aug 18 18:40:43 2024] ? __warn+0xa4/0x220 > > [Sun Aug 18 18:40:43 2024] ? netfs_subreq_terminated+0x3f0/0x4b0 [netfs] > > [Sun Aug 18 18:40:43 2024] ? report_bug+0x1d4/0x1e0 > > [Sun Aug 18 18:40:43 2024] ? handle_bug+0x42/0x80 > > [Sun Aug 18 18:40:43 2024] ? exc_invalid_op+0x18/0x50 > > [Sun Aug 18 18:40:43 2024] ? asm_exc_invalid_op+0x1a/0x20 > > [Sun Aug 18 18:40:43 2024] ? irq_work_claim+0x1e/0x40 > > [Sun Aug 18 18:40:43 2024] ? netfs_subreq_terminated+0x3f0/0x4b0 [netfs] > > > > $ git log --oneline -3 > > b5e99e6c6dcd (HEAD -> for-next, origin/for-next) smb3: fix problem > > unloading module due to leaked refcount on shutdown > > e4be320eeca8 smb3: fix broken cached reads when posix locks > > 47ac09b91bef (tag: v6.11-rc4, origin/master, origin/HEAD, > > linus/master, master) Linux 6.11-rc4 > > > > > > Ideas? > > > > -- > > Thanks, > > > > Steve > > > > -- > Thanks, > > Steve -- Thanks, Steve
