On 12/5/23 08:48, Namjae Jeon via samba-technical wrote:
I found that name strings of SMB2_CREATE_ALLOCATION_SIZE are different between samba and cifs/ksmbd like the following. In the MS-SMB2 specification, the name of SMB2_CREATE_ALLOCATION_SIZE is defined as AISi. Is it a typo in the specification or is samba defining it incorrectly? samba-4.19.2/libcli/smb/smb2_constants.h : #define SMB2_CREATE_TAG_ALSI "AlSi" /fs/smb/common/smb2pdu.h : #define SMB2_CREATE_ALLOCATION_SIZE "AISi"
looks like a bug in MS-SMB2: they have the value as 0x416c5369, which is "AlSi", with an "l" like in "l"ake.
Adding dochelp to cc. @dochelp: looks like you have a small bug in MS-SMB2. :) -slow
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature
