Re: [PATCH v3] ksmbd: remove unnecessary generic_fillattr in smb2_open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2022년 8월 11일 (목) 오후 3:51, Christoph Hellwig <hch@xxxxxxxxxxxxx>님이 작성:
>
> On Thu, Aug 11, 2022 at 03:36:59PM +0900, Hyunchul Lee wrote:
> > +     rc = ksmbd_vfs_getattr(&path, &stat);
> > +     if (rc) {
> > +             generic_fillattr(user_ns, d_inode(path.dentry), &stat);
> > +             rc = 0;
> > +     }
>
> Why is this calling generic_fillattr at all?  generic_fillattr is a
> helper for file systems.  Consumers of the file system API like ksmbd
> must never use it directly.

I will remove generic_fillattr.
Thank you for your comment.


-- 
Thanks,
Hyunchul




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux