Re: [PATCH v3] ksmbd: remove unnecessary generic_fillattr in smb2_open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 11, 2022 at 03:36:59PM +0900, Hyunchul Lee wrote:
> +	rc = ksmbd_vfs_getattr(&path, &stat);
> +	if (rc) {
> +		generic_fillattr(user_ns, d_inode(path.dentry), &stat);
> +		rc = 0;
> +	}

Why is this calling generic_fillattr at all?  generic_fillattr is a
helper for file systems.  Consumers of the file system API like ksmbd
must never use it directly.



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux