On Sat, Mar 19, 2022 at 8:45 PM Tom Talpey <tom@xxxxxxxxxx> wrote: > > On 3/19/2022 9:22 PM, Namjae Jeon wrote: > > 2022-03-20 3:34 GMT+09:00, Steve French <smfrench@xxxxxxxxx>: > >> They probably should be always 'u64' everywhere (not le64) and change > >> the code back in fs/smbfs_common/smb2pdu.h (was this due to ksmbd > >> using the file and converting these fields in fs/smbfs_common) rather > >> than the ones you changed > > I don't understand why only FileId fields should be declared as u64 not le64. > > Because they're opaque to the client. > > > It means that FileID doesn't need byteswap in client? > > Correct. They are tested only for equality, or are placed in a packet > verbatim and sent back to the server. > > > samba seems to > > stores them in little-endian byte order. > > Again, unnecessary and dangerous, IMO. Agree - safer to have opaque fields to be host endian, and a tiny bit faster. -- Thanks, Steve
