On 3/19/2022 12:23 AM, Steve French wrote:
Any comments on Paulo's patch? It fixes an endian conversion problem that can affect file ids used on big endian archs. I will add cc: stable https://git.cjr.nz/linux.git/commit/?h=cifs-bad-fid-fixes&id=a857bb6b15646a7946fafb281878ddf498107dc3
It seems a bad idea to be storing opaque fields in le64 integers, then byteswapping them when they go back on the wire. Wouldn't it be better to make them u8[8] arrays and just use memcpy/memcmp?
Tom.
