Agreed. On June 23, 2021 8:48:24 AM GMT-03:00, "Aurélien Aptel" <aaptel@xxxxxxxx> wrote: >Steve French <smfrench@xxxxxxxxx> writes: >> We weren't checking if tcon is null before setting dfs path, >> although we check for null tcon in an earlier assignment statement. > >If tcon is NULL there is no point in continuing in that function, we >should have exited earlier. > >If tcon is NULL it means mount_get_conns() failed so presumably rc will >be != 0 and we would goto error. > >I don't think this is needed. We could change the existing check after >the loop to this you really want to be safe: > > if (rc || !tcon) > goto error; > > >Cheers,
