Steve French <smfrench@xxxxxxxxx> writes: > We weren't checking if tcon is null before setting dfs path, > although we check for null tcon in an earlier assignment statement. If tcon is NULL there is no point in continuing in that function, we should have exited earlier. If tcon is NULL it means mount_get_conns() failed so presumably rc will be != 0 and we would goto error. I don't think this is needed. We could change the existing check after the loop to this you really want to be safe: if (rc || !tcon) goto error; Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
