Shyam Prasad N <nspmangalore@xxxxxxxxx> writes: > @Paulo Alcantara That would be great if you can help testing my > changes. Please test with these new changes. OK. >> The super is only used for providing cifs_sb_info::origin_fullpath as key to find the corresponding failover targets in referral cache. > I'm wondering what would happen if there are multiple tcons to the > same origin_fullpath (possibly in different sessions)? That is certainly a problem, indeed. I'm waiting for the DFS tests to finish and then send a series that contains a potential fix for that -- e.g. not sharing TCP servers when mounting DFS shares. We used to not share tcons with DFS mounts because they might contain different prefix paths but connected to same share, however that wasn't enough because multiple DFS mounts may connect to same target servers, although they might failover to completely different servers. > Also, doesn't failover targets apply to each channel under a session? > Shouldn't we switch targets on reconnect of secondary channels too? That's a interesting question. I recall discussing this with Aurelien some time ago while running a few DFS + multichannel tests. So yes, I agree with you that when we successfully reconnect to failover target (primary channel), then we should also update all secondary channels with the new server's ip address and reconnect them.
