Re: [PATCH] cifs: add support for FALLOC_FL_COLLAPSE_RANGE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ronnie,

url:    https://github.com/0day-ci/linux/commits/Ronnie-Sahlberg/cifs-add-support-for-FALLOC_FL_COLLAPSE_RANGE/20210326-093328
base:   git://git.samba.org/sfrench/cifs-2.6.git for-next
config: i386-randconfig-m021-20210325 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

New smatch warnings:
fs/cifs/smb2ops.c:3654 smb3_collapse_range() warn: statement has no effect 5
fs/cifs/smb2ops.c:3654 smb3_collapse_range() error: uninitialized symbol 'rc'.

Old smatch warnings:
fs/cifs/smb2ops.c:3660 smb3_collapse_range() warn: statement has no effect 5
fs/cifs/smb2ops.c:3660 smb3_collapse_range() error: uninitialized symbol 'rc'.

vim +3654 fs/cifs/smb2ops.c

0536911dc253bd Ronnie Sahlberg 2021-03-26  3643  static long smb3_collapse_range(struct file *file, struct cifs_tcon *tcon,
0536911dc253bd Ronnie Sahlberg 2021-03-26  3644  			    loff_t off, loff_t len)
0536911dc253bd Ronnie Sahlberg 2021-03-26  3645  {
0536911dc253bd Ronnie Sahlberg 2021-03-26  3646  	int rc;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3647  	unsigned int xid;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3648  	struct cifsFileInfo *cfile = file->private_data;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3649  	__le64 eof;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3650  
0536911dc253bd Ronnie Sahlberg 2021-03-26  3651  	xid = get_xid();
0536911dc253bd Ronnie Sahlberg 2021-03-26  3652  
0536911dc253bd Ronnie Sahlberg 2021-03-26  3653  	if (off + len < off) {
0536911dc253bd Ronnie Sahlberg 2021-03-26 @3654  		rc -EFBIG;

Missing = character.

0536911dc253bd Ronnie Sahlberg 2021-03-26  3655  		goto out;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3656  	}
0536911dc253bd Ronnie Sahlberg 2021-03-26  3657  
0536911dc253bd Ronnie Sahlberg 2021-03-26  3658  	if (off >= i_size_read(file->f_inode) ||
0536911dc253bd Ronnie Sahlberg 2021-03-26  3659  	    off + len >= i_size_read(file->f_inode)) {
0536911dc253bd Ronnie Sahlberg 2021-03-26  3660  		rc -EINVAL;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3661  		goto out;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3662  	}
0536911dc253bd Ronnie Sahlberg 2021-03-26  3663  
0536911dc253bd Ronnie Sahlberg 2021-03-26  3664  	rc = smb2_copychunk_range(xid, cfile, cfile, off + len,
0536911dc253bd Ronnie Sahlberg 2021-03-26  3665  				  i_size_read(file->f_inode) - off - len, off);
0536911dc253bd Ronnie Sahlberg 2021-03-26  3666  	if (rc < 0)
0536911dc253bd Ronnie Sahlberg 2021-03-26  3667  		goto out;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3668  
0536911dc253bd Ronnie Sahlberg 2021-03-26  3669  	eof = i_size_read(file->f_inode) - len;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3670  	rc = SMB2_set_eof(xid, tcon, cfile->fid.persistent_fid,
0536911dc253bd Ronnie Sahlberg 2021-03-26  3671  			  cfile->fid.volatile_fid, cfile->pid, &eof);
0536911dc253bd Ronnie Sahlberg 2021-03-26  3672  	if (rc < 0)
0536911dc253bd Ronnie Sahlberg 2021-03-26  3673  		goto out;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3674  
0536911dc253bd Ronnie Sahlberg 2021-03-26  3675  	rc = 0;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3676   out:
0536911dc253bd Ronnie Sahlberg 2021-03-26  3677  	free_xid(xid);
0536911dc253bd Ronnie Sahlberg 2021-03-26  3678  	return rc;
0536911dc253bd Ronnie Sahlberg 2021-03-26  3679  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux