Re: [PATCH] cifs: add support for FALLOC_FL_COLLAPSE_RANGE

[kernel test robot <lkp@xxxxxxxxx>]

Hi Ronnie,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on cifs/for-next]
[also build test WARNING on v5.12-rc4 next-20210325]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ronnie-Sahlberg/cifs-add-support-for-FALLOC_FL_COLLAPSE_RANGE/20210326-093328
base:   git://git.samba.org/sfrench/cifs-2.6.git for-next
config: x86_64-randconfig-a015-20210325 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project f490a5969bd52c8a48586f134ff8f02ccbb295b3)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/0536911dc253bdf2243c8054b5f6fbd256dcdb49
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ronnie-Sahlberg/cifs-add-support-for-FALLOC_FL_COLLAPSE_RANGE/20210326-093328
        git checkout 0536911dc253bdf2243c8054b5f6fbd256dcdb49
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   fs/cifs/smb2ops.c:3654:6: warning: expression result unused [-Wunused-value]
                   rc -EFBIG;
                   ~~ ^~~~~~
   fs/cifs/smb2ops.c:3660:6: warning: expression result unused [-Wunused-value]
                   rc -EINVAL;
                   ~~ ^~~~~~~
>> fs/cifs/smb2ops.c:3654:3: warning: variable 'rc' is uninitialized when used here [-Wuninitialized]
                   rc -EFBIG;
                   ^~
   fs/cifs/smb2ops.c:3646:8: note: initialize the variable 'rc' to silence this warning
           int rc;
                 ^
                  = 0
   3 warnings generated.


vim +/rc +3654 fs/cifs/smb2ops.c

  3642	
  3643	static long smb3_collapse_range(struct file *file, struct cifs_tcon *tcon,
  3644				    loff_t off, loff_t len)
  3645	{
  3646		int rc;
  3647		unsigned int xid;
  3648		struct cifsFileInfo *cfile = file->private_data;
  3649		__le64 eof;
  3650	
  3651		xid = get_xid();
  3652	
  3653		if (off + len < off) {
> 3654			rc -EFBIG;
  3655			goto out;
  3656		}
  3657	
  3658		if (off >= i_size_read(file->f_inode) ||
  3659		    off + len >= i_size_read(file->f_inode)) {
  3660			rc -EINVAL;
  3661			goto out;
  3662		}
  3663	
  3664		rc = smb2_copychunk_range(xid, cfile, cfile, off + len,
  3665					  i_size_read(file->f_inode) - off - len, off);
  3666		if (rc < 0)
  3667			goto out;
  3668	
  3669		eof = i_size_read(file->f_inode) - len;
  3670		rc = SMB2_set_eof(xid, tcon, cfile->fid.persistent_fid,
  3671				  cfile->fid.volatile_fid, cfile->pid, &eof);
  3672		if (rc < 0)
  3673			goto out;
  3674	
  3675		rc = 0;
  3676	 out:
  3677		free_xid(xid);
  3678		return rc;
  3679	}
  3680	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip