On Thu, Feb 11, 2021 at 11:12 AM Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > > Hi Shyam, > > The output looks very informative! I have one comment: > > Servers: > 1) ConnectionId: 0x1 > Number of credits: 326 Dialect 0x311 > TCP status: 1 Instance: 1 > Local Users To Server: 1 SecMode: 0x1 Req On Wire: 0 > In Send: 0 In MaxReq Wait: 0 > > Sessions: > 1) Name: 10.229.158.38 Uses: 1 Capability: 0x300077 Session Status: 1 > ^^^^ > Isn't this name (or hostname) a property of the connection? I would > expect an IP or a hostname to be printed in the connection settings > above. The "Name:" (actually the IPv4 or IPv6 address, not the name) is from ses->serverName not from the connection (tcp socket). We should probably change from "Name" to "Address" or equivalent in /proc/fs/cifs/DebugData See fs/cifs/connect.c lines 1841 and 1843 The "name" field could be added to the /proc/fs/cifs/DebugData output for the TCP_Server_Info struct by e.g. dumping the "hostname" and/or "server_RFC1001_name" fields. -- Thanks, Steve
