the multiline strings if they make it more readable are fine (probably fine here), so can ignore "quoted string split across lines" warning On Sat, Feb 6, 2021 at 10:14 PM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > Attached patch with a few formatting changes per checkpatch.pl. > However, some of the multi-line strings look better when the strings > are in separate lines. Please let me know if you still feel they > should go into a single line. > > Regards, > Shyam > > On Thu, Feb 4, 2021 at 6:45 AM Aurélien Aptel <aaptel@xxxxxxxx> wrote: > > > > > > Code looks ok. > > > > There are little style issues reported by checkpatch.pl: Trailing > > whitespaces and comma+space stuff; ignore the columns ones. > > > > Cheers, > > -- > > Aurélien Aptel / SUSE Labs Samba Team > > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE > > GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München) > > > > > -- > Regards, > Shyam -- Thanks, Steve
